Repository navigation
feat: Solution scaling for thermal single phase - #3979
Open
frankfeifan wants to merge 18 commits into
Open
frankfeifan wants to merge 18 commits into
frankfeifan wants to merge 18 commits into
Conversation
frankfeifan
requested review from
OmarDuran,
dkachuma,
rrsettgast and
tjb-ltk
as code owners
February 22, 2026 21:05
tjb-ltk
reviewed
Feb 23, 2026
tjb-ltk
approved these changes
Feb 23, 2026
tjb-ltk
left a comment
tjb-ltk
left a comment
Contributor
There was a problem hiding this comment.
Good addition and cleanup of single/compositional well scaling paramerters
frankfeifan
added
flag: ready for review
ci: run integrated tests
frankfeifan
commented
Feb 25, 2026
…ScalingForSinglePhase
…ling for single phase FVM
frankfeifan
added
ci: run device builds
dkachuma
reviewed
Oct 20, 2026
dkachuma
left a comment
dkachuma
left a comment
Contributor
There was a problem hiding this comment.
Is it possible to extend maxAbsoluteTemperatureChange to the multiphase case as well?
Contributor
Author
It's possible. |
Contributor
|
@jhuang2601 and @OmarDuran will provide feedback. |
jhuang2601
approved these changes
Nov 5, 2026
Co-authored-by: Jian Huang <53012159+jhuang2601@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to enable solution scaling for the thermal single-phase FVM and well models. Following changes are made:
maxAbsoluteTemperatureChangelimit and a thermal scaling kernel to single-phase flow.CompositionalMultiphaseFlow, adds ascalingTypeoption (GlobalorLocal) toSinglePhaseFVM, withScalingTypemoved to a sharedflowSolverUtilitiesheader. DefaultscalingTypeisGlobal.LocalrequireslineSearchAction="None".maxAbsolutePressureChangeandmaxAbsoluteTemperatureChangeto single-phase wells throughWellControls, used to compute a global scaling factor for the well update.maxAbsoluteTemperatureChangeinCompositionalMultiphaseFVMandCompositionalMultiphaseWell. As with pressure, when set it overridesmaxRelativeTemperatureChange.Note: now compositional multi-phase and single-phase well models both use global scaling only. In other words, a single scaling factor is applied to every well variable. This single factor is obtained as the minimum over all well elements and wells, and primary variables (pressure, temperature, and component density for compositional solver). In the coupled reservoir solver with
scalingType="Global"in the reservoir region, the factor also accounts for the minmum of the reservor solver. Further study is needed to check if a per-element scaling factor field array is essential for the well region.